Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 28, 2024

If you try to run the sqlparser benchmarks it fails to compile:

cd sqlparser_bench
cargo clippy --all-targets
error[E0277]: can't compare `std::string::String` with `sqlparser::ast::Statement`
  --> benches/sqlparser_bench.rs:82:13
   |
82 |             assert_eq!(formatted_query, large_statement);
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no implementation for `std::string::String == sqlparser::ast::Statement`
   |

b.iter(|| {
let formatted_query = large_statement.to_string();
assert_eq!(formatted_query, large_statement);
let _formatted_query = large_statement.to_string();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this assert was meant to show, so I removed it.

@alamb
Copy link
Contributor Author

alamb commented Dec 28, 2024

It does occur to me that this is not covered by CI. Maybe we should move the benchmark binary into the normal sqlparser crate (which I think would be more standard) rather than having an entirely separate crate (sqlparser_bench) -- that would also ensure the benchmark is covered by CI tests 🤔

@alamb
Copy link
Contributor Author

alamb commented Dec 28, 2024

It does occur to me that this is not covered by CI. Maybe we should move the benchmark binary into the normal sqlparser crate (which I think would be more standard) rather than having an entirely separate crate (sqlparser_bench) -- that would also ensure the benchmark is covered by CI tests 🤔

@iffyio
Copy link
Contributor

iffyio commented Dec 29, 2024

Thanks @alamb!

@iffyio iffyio merged commit 539db9f into apache:main Dec 29, 2024
8 checks passed
@alamb alamb deleted the alamb/fix_bench2 branch December 29, 2024 15:03
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants